Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DevOps shared github runners #226

Merged
merged 16 commits into from
Jul 10, 2023
Merged

Use DevOps shared github runners #226

merged 16 commits into from
Jul 10, 2023

Conversation

hugobuddel
Copy link
Collaborator

In particular the miminmumdependencies test is useful, as that went wrong with earlier updates

@codecov
Copy link

codecov bot commented Jun 14, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +5.69 🎉

Comparison is base (6626eeb) 75.17% compared to head (c10c211) 80.87%.

Additional details and impacted files 
@@              Coverage Diff               @@
##           dev_master     #226      +/-   ##
==============================================
+ Coverage       75.17%   80.87%   +5.69%     
==============================================
  Files             152      143       -9     
  Lines           15637    14561    -1076     
==============================================
+ Hits            11755    11776      +21     
+ Misses           3882     2785    -1097
Impacted Files Coverage Δ
scopesim/tests/tests_commands/test_UserCommands.py 98.23% <100.00%> (-0.05%) ⬇️
...opesim/tests/tests_effects/test_SkycalcTERCurve.py 87.50% <100.00%> (-2.50%) ⬇️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hugobuddel hugobuddel mentioned this pull request Jul 8, 2023
Closed
@hugobuddel hugobuddel requested a review from teutoburg July 8, 2023 11:47
@hugobuddel
Copy link
Collaborator Author

With this change, all projects have a similar framework:

  • using pyproject.toml
  • using tests from DevOps repository

teutoburg
teutoburg approved these changes Jul 8, 2023
View reviewed changes
Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems very useful 👍

@hugobuddel hugobuddel merged commit a8fa7d0 into dev_master Jul 10, 2023
19 checks passed
@hugobuddel hugobuddel deleted the hb/usedevops branch July 10, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teutoburg teutoburg teutoburg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hugobuddel @teutoburg